Re: [PATCH 5/7] AMD Geode GX/LX support

[Alan Cox]

On Llu, 2005-10-03 at 11:58 -0600, Jordan Crouse wrote:

> +
> +	hwif->udma_four = w80;  /* w80 = 1 if a 80 conductor line is attached */
> +
> +	if (hwif->mate)
> +		hwif->serialized = hwif->mate->serialized = 1;

Is this needed, it doesn't seem to be in the databook or errata ?


> Index: linux-2.6.14-rc2-mm2/drivers/ide/pci/cs5535.h
> ===================================================================
> --- /dev/null
> +++ linux-2.6.14-rc2-mm2/drivers/ide/pci/cs5535.h
> @@ -0,0 +1,72 @@

Please put the private structure into the .c file as the other code now
does. Its a tidy up that wants picking up.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/