Re: [PATCH] release_resource() check for NULL resource

[Russell King]

On Mon, Oct 03, 2005 at 04:12:41PM +0300, Pekka J Enberg wrote:
> On Mon, 3 Oct 2005, Russell King wrote:
> > However, I think you missed my point though.  release_resource() is
> > _not_ the counterpart of request_region().  It's the counter-part of
> > request_resource() which does not allocate any memory itself.
> 
> So what is the counter-part for request_region if it's not 
> release_resource? As far as I can tell, release_region is marked as 
> compatability cruft.

As I stated in previous mails, release_region() undoes all the effects
of request_region().  If you take a look at kernel/resource.c, you'll
notice that request_region() is also compatibility cruft as well.

> But anyway, my point is that dealing with NULL in many release functions 
> is beneficial for releasing a partially initialized state.

If that's what you think, thanks for volunteering to fix all the
sysfs and driver model interfaces as well.  The following examples
below functionally correspond to the request_resource()/
release_resource() and would also require fixing if what you think
were true.

request_resource	|	release_resource
------------------------+---------------------------
device_register		|	device_unregister
bus_register		|	bus_unregister
driver_register		|	driver_unregister

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/