Re: [PATCH] release_resource() check for NULL resource

From: Pekka J Enberg
Date: Mon Oct 03 2005 - 07:55:05 EST


On Mon, 3 Oct 2005, Russell King wrote:
> And the above is buggy. request_region() allocates memory.
> release_resource() unregisters the resource but does _not_
> free the allocated memory.

Indeed but that's besides the point as kfree() deals with NULLs fine.

On Mon, 3 Oct 2005, Russell King wrote:
> On the other hand, release_region() is the counter-part of
> request_region() and should be used to release resources
> created by request_region().

Right. To me, it makes sense for the release counter-part accept NULL if
the allocation/initialization function can return it.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/