Re: [PATCH] release_resource() check for NULL resource

[Jesper Juhl]

On 10/3/05, Ben Dooks <ben-linux@xxxxxxxxx> wrote:
> On Sun, Oct 02, 2005 at 10:39:22AM -0700, Randy.Dunlap wrote:
> > On Sun, 2 Oct 2005 18:03:18 +0100 Ben Dooks wrote:
> >
> > > If release_resource() is passed a NULL resource
> > > the kernel will OOPS.
> >
> > does this actually happen?  you are fixing a real oops?
> > if so, what driver caused it?
>
> I was developing a couple of new drivers, and found
> that this does not behave like kfree() which does check
> for NULL paramemters. I belive it would be helpful if
> functions like this followed the example of kfree().
>
I would agree that it makes sense for resource release functions to be
written defensively and be able to cope with being passed a NULL
resource, just like kfree(), vfree(), crypto_free_tfm() and others are
already doing.
Seems safer and allows us to get rid of checks for NULL before calling
such functions thus making code simpler, more readable and in some
cases smaller.

Just my 0.02euro

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/