Re: [PATCH] nvidiafb: PPC & mode setting fixes (#2)

[Benjamin Herrenschmidt]

On Sun, 2005-10-02 at 15:08 +0800, Antonino A. Daplas wrote:
> Benjamin Herrenschmidt wrote:
> > (This version removes a useless bit that slipped in the previous one)
> > 
> > This patch fixes a couple of things in nvidiafb:
> > 
> >  - The code for retreiving the mode from Open Firmware was broken. It
> > would crash at boot and was copied from the old rivafb code that didn't
> > work very well (I'll update rivafb too one of these days).
> 
> What do you think of making EDID retrieval from the OF generic?  Or is
> it too much hassle?

Well, at this point, it only really concerns nvidia and ati's and their
respective firmwares seem to expose some properties a bit differently...
The radeon code would probably work for nvidia though as I'm not trying
to get the connector type for nvidiafb yet, but if I ever try, it seems
the stuff is a bit different.

I'd say let's keep them separate for now, I may put them in a common
place some day ..

Ben.

> Thanks for the fix :-)  
> 
> Acked-by: Antonino Daplas <adaplas@xxxxxxx>

Ok, if you confirm it doesn't seem to do any regression on other
hardware (I don't have any other nvidia hw to test with), I'd like it
upstream asap (probably too late for 2.6.14 though).

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/