Re: [PATCH] usb/core/hcd-pci.c: don't free_irq() on suspend

From: Daniel Ritz
Date: Sat Oct 01 2005 - 15:47:27 EST


[ restored some of the cc: list of the original thread ]

On Saturday 01 October 2005 01.38, Greg KH wrote:
> <top-post on purpose...>
>
> Daniel, are you sure about this patch (the second part specifically)?

well, the first hunk doesn't make sense without the second and vice versa,
isn't it? to answer your question: yes.

> It directly conflicts with a set of patches in my current tree in this
> area that fix all of the reported suspend/resume issues with usb host
> controllers (that patch series written by David Brownell.)
>
> Yeah, I see that we shouldn't have been dropping the irq on suspend and
> getting a new one on resume, that's not good and could have caused
> problems for people.
>
> But could you at least drop the linux-usb-devel mailing list a note that
> you are having issues, and post the proposed patch? Directly sending it

i don't have problems, it was rafael...i just happend to look at it because
yenta_socket was involved...see the following link for more background:
http://marc.theaimsgroup.com/?t=112275164900002&r=1&w=4

> to Linus is a bit rude, it's not like the USB developers aren't

sorry for that, but i actually asked for a round in -mm. it just happend
that linus was on to: and the rest on cc: by pressing reply-to-all in kmail

the original thread
http://marc.theaimsgroup.com/?t=112618280600003&r=1&w=4

> responsive to emails (yeah, I've been a bit slow at times these past few
> weeks, but my traveling all over the place for the past month is now
> over, and I'm not going anywhere for a long time...)
>
> David, this conflicts with your usb/usb-pm-06.patch in my quilt tree.
> I'll try to resolve the merge with my best guess, but you should check
> that I got it right...
>
> thanks,
>
> greg k-h
>

rgds
-daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/