Re: [PATCH 2/2] HPET: make frequency calculations 32 bit safe

[Karsten Wiese]

> --- linux-2.6.13.orig/drivers/char/hpet.c       2005-09-22 11:10:01.000000000 +0200
> +++ linux-2.6.13/drivers/char/hpet.c    2005-09-22 12:08:48.000000000 +0200
> @@ -78,7 +78,7 @@ struct hpets {
>         struct hpet __iomem *hp_hpet;
>         unsigned long hp_hpet_phys;
>         struct time_interpolator *hp_interpolator;
> -       unsigned long hp_period;
> +       unsigned long long hp_tick_freq;
An 'unsigned long' is enough.
Are we expecting hpets stepping at more than 4GHz?
They are called 'legacy' in some docs already ;-)
Here the via8237's hpet runs at ~14MHz.

>         unsigned long hp_delta;
>         unsigned int hp_ntimer;
>         unsigned int hp_which;

Tested OK on i386 2.6.13-rt14 with above nitpick applied.

      Karsten


	

	
		
___________________________________________________________ 
Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/