Re: [PATCH 3/3] fuse: check O_DIRECT

[Andrew Morton]

Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
>
> Check O_DIRECT and return -EINVAL error in open.  dentry_open() also
> checks this but only after the open method is called.  This patch
> optimizes away the unnecessary upcalls in this case.
> 
> Signed-off-by: Miklos Szeredi <miklos@xxxxxxxxxx>
> 
> Index: linux/fs/fuse/file.c
> ===================================================================
> --- linux.orig/fs/fuse/file.c	2005-09-21 11:55:45.000000000 +0200
> +++ linux/fs/fuse/file.c	2005-09-23 15:24:23.000000000 +0200
> @@ -23,6 +23,10 @@ int fuse_open_common(struct inode *inode
>  	struct fuse_file *ff;
>  	int err;
>  
> +	/* VFS checks this, but only _after_ ->open() */
> +	if (file->f_flags & O_DIRECT)
> +		return -EINVAL;
> +
>  	err = generic_file_open(inode, file);
>  	if (err)
>  		return err;

This hardly seems worth optimising for?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/