Re: [PATCH] reduce sizeof(struct file)

From: Christoph Hellwig
Date: Fri Sep 23 2005 - 05:06:15 EST


On Fri, Sep 23, 2005 at 12:02:18PM +0200, Eric Dumazet wrote:
> Hi all
>
> Now that RCU applied on 'struct file' seems stable, we can place f_rcuhead
> in a memory location that is not anymore used at call_rcu(&f->f_rcuhead,
> file_free_rcu) time, to reduce the size of this critical kernel object.
>
> The trick I used is to move f_rcuhead and f_list in an union and defining
> macros to access f_list and f_rcuhead
>
> Unfortunatly f_list was also used in IPVS so I had to change
> include/net/ip_vs.h and net/ipv4/ipvs/ip_vs_ctl.c, changing their f_list to
> ipvs_f_list to avoid name clash.
>
> (This is why I send this mail to IPVS maintainers)

Please just change all callers to use the union, there's not very many
of them.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/