Re: [uml-devel] [PATCH 06/10] uml: run mconsole "sysrq" in processcontext

From: Andrew Morton
Date: Fri Sep 23 2005 - 02:50:51 EST


Jeff Dike <jdike@xxxxxxxxxxx> wrote:
>
> On Thu, Sep 22, 2005 at 09:20:20PM +0200, Blaisorblade wrote:
> > sysrq t is broken (and stays),
>
> There's a fix on the way for that. This has nothing to do with interrupt
> context anyway.
>
> > but additionally there are some warnings from
> > some commands (enable sleep inside spinlock checking and spinlock debugging),
> > which go to the down_read inside handle_page_fault IIRC. So try to run in
> > process context.
>
> Which ones? They should be fixed.
>
> It is fairly fundamental to sysrq that it work from interrupt context. You
> may be diagnosing a system which can't context switch any more.
>
> This patch should be dropped, and the real problems fixed.
>

Well Linus has just merged this patch. If you hadn't removed me from the
cc yesterday this would not have happened.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/