Re: making kmalloc BUG() might not be a good idea

[Nick Piggin]

David S. Miller wrote:

> I'm sort-of concerned about this change:
>
>    [PATCH] __kmalloc: Generate BUG if size requested is too large.
>
> it opens a can of worms, and stuff that used to generate
> -ENOMEM kinds of failures will now BUG() the kernel.
>
> Unless you're going to audit every user triggerable
> path for proper size limiting, I think we should revert
> this change.
>
> Thanks.
>  

Making it WARN might be a good compromise.


Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/