Re: [PATCH 2.6.14-rc2] fix incorrect mm->hiwater_vm and mm->hiwater_rss

[Frank van Maarseveen]

On Wed, Sep 21, 2005 at 11:05:14AM -0700, Jay Lan wrote:
> 
> System accounting improvement is needed because those accouting
> information were needed and used at real customer sites.
> 
> So, yes, the basic system accounting code (ie, BSD) needs
> improvement, and, no, i am done with sys acct data collection.

Ok, but how do you verify that the mm->hiwater_* counters are correct to
any degree? because it appears that at least hiwater_vm is incorrect in
post-2.6.11 and not by a small amount.


What about calling

static inline void grow_total_vm(struct mm_struct *mm, unsigned long increase)
{
	mm->total_vm += increase;
	if (mm->total_vm > mm->hiwater_vm)
		mm->hiwater_vm = mm->total_vm;
}

whenever total_vm is increased and possibly doing something similar for rss at
different places? If it is not on the fast path then it's not necessary to
#ifdef the thing anywhere.

-- 
Frank
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/