Re: [PATCH] NTP shift_right cleanup (v. A3)

[Nick Piggin]

john stultz wrote:

> +/* Required to safely shift negative values */
> +#define shift_right(x, s) ({	\
> +	__typeof__(x) __x = (x);	\
> +	__typeof__(s) __s = (s);	\
> +	__x < 0 ? -(-__x >> __s) : __x >> __s;	\
> +})
> +

I'd hate to be the one to make you do another version of this ;)

However, how about having something more descriptive than shift_right?
signed_shift_right / shift_right_signed, maybe?

Nick


Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/