Re: I request inclusion of reiser4 in the mainline kernel

From: James Lamanna
Date: Tue Sep 20 2005 - 18:51:37 EST


On 9/20/05, Vadim Lobanov <vlobanov@xxxxxxxxxxxxx> wrote:
> On Tue, 20 Sep 2005, James Lamanna wrote:
>
> > On 9/20/05, Stephen Pollei <stephen.pollei@xxxxxxxx> wrote:
> > >On 9/20/05, Hans Reiser <reiser@xxxxxxxxxxx> wrote:
> > > > Horst von Brand wrote:
> > > > >Nikita Danilov <nikita@xxxxxxxxxxxxx> wrote:

> > What about #warning / #error in this case?
> >
> > #if defined(DEBUG_THIS) || defined(DEBUG_THAT)
> > int znode_is_loaded(const struct znode *z);
> > #else
> > #error znode_is_loaded is unavailable when not debugging
> > #endif
> >
> > That would certainly break the compile.
>
> Except that breaks the compile unconditionally, not just when someone
> tries to use the function when they shouldn't. I don't think a flat
> error will work here, but instead something along the lines of a
> __attribute__((error)) on the function is needed.

Oh duh. It would wouldn't it :)
Too much on my mind today.

>
> > -- James Lamanna
> > -
>
> -VadimL
>

-- James Lamanna
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/