Re: [PATCH] scripts - use $OBJDUMP to get correct objdump (cross compile)

[Bodo Eggert]

Keith Owens <kaos@xxxxxxxxxx> wrote:

> +my $objdump;
> +if (exists($ENV{'OBJDUMP'})) {
> +     $objdump = $ENV{'OBJDUMP'};

Having a typo in the environment shouldn't silently do something different
from what's requested. Use something like

my @objdump = ( (defined $ENV{'OBJDUMP'})? $ENV{'OBJDUMP'} :
                                           "/usr/bin/objdump",
               '-s', '-j');
> +} else {
> +     $objdump = 'objdump';
> +}
> +$objdump .= ' -s -j .comment';

Having a space as the option delimiter will break if the path to objdump
contains a space. Therefore you'll need to use an array.

-- 
Ich danke GMX dafür, die Verwendung meiner Adressen mittels per SPF
verbreiteten Lügen zu sabotieren.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/