Re: I request inclusion of reiser4 in the mainline kernel

[Jens Axboe]

On Sun, Sep 18 2005, Hans Reiser wrote:
> Linux kernel code is getting better, and Andrew Morton's code is
> especially good, but for the most part it's unnecessarily hard to read. 
> Look at the elevator code for instance.  Ugh.

That's pretty bold, coming from someone who cannot even figure out how
to follow the style guidelines of the kernel.

The elevator core api is so trivial, I don't believe you find this hard
to read. The individual io schedulers tend to have comments in functions
that aren't immediately obvious. So I'm curious, what do part makes you
go 'ugh'?

So please explain or refrain from making stupid unwarranted comments
about other peoples code.

> That is why I just say "make it easy to read and I don't care how you do
> that so long as it works."

Then why do you insist on commenting your code differently than everyone
else ('everyone' means the kernel here, since that is your target)?

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/