Re: [linux-usb-devel] URB_ASYNC_UNLINK b0rkage

[Alexey Dobriyan]

On Sun, Sep 18, 2005 at 05:30:50PM -0400, Alan Stern wrote:
> On Sun, 18 Sep 2005, Alexey Dobriyan wrote:
> > drivers/usb/host/hc_crisv10.c:	if (urb->transfer_flags & URB_ASYNC_UNLINK) {
> > drivers/usb/host/hc_crisv10.c:		/* If URB_ASYNC_UNLINK is set:
> > drivers/usb/host/hc_crisv10.c:		warn("URB_ASYNC_UNLINK set, ignoring.");
> > drivers/usb/misc/uss720.c:	/* rq->urb->transfer_flags |= URB_ASYNC_UNLINK; */
> > drivers/isdn/hisax/st5481_b.c:	b_out->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> > drivers/isdn/hisax/st5481_b.c:	b_out->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> > drivers/isdn/hisax/st5481_usb.c:	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
> > drivers/isdn/hisax/st5481_usb.c:	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
> > Documentation/usb/URB.txt:the URB_ASYNC_UNLINK flag in urb->transfer flags before calling
> 
> hc_crisv10 is long out-of-date and doesn't even build, as you saw.

Just grepped.

> Is anyone still using it?  It probably should be removed from the
> Makefile.

> In my kernel tree, the st5481 source files don't include the lines you 
> show.  What source version are you using?

23 hours ago:

commit 61ffcafafb3d985e1ab8463be0187b421614775c
Author: Karsten Keil <kkeil@xxxxxxx>
Date:   Sat Sep 17 23:52:42 2005 +0200

    [PATCH] Fix ST 5481 USB driver

    The old driver was not fully adapted to new USB ABI and does not
    work.

+	in->urb[0]->transfer_flags |= URB_ASYNC_UNLINK;
 	usb_unlink_urb(in->urb[0]);
+	in->urb[1]->transfer_flags |= URB_ASYNC_UNLINK;
 	usb_unlink_urb(in->urb[1]);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/