Re: [PATCH 04/11] hpt366: write the full 4 bytes of ROM address,not just low 1 byte

[David Lang]

didn't Linus find similar bugs in a couple of the other hpt drivers as 
well? if so can they be fixed at the same time?

David Lang

On Wed, 14 Sep 2005, Chris Wright wrote:

> Date: Wed, 14 Sep 2005 18:03:47 -0700
> From: Chris Wright <chrisw@xxxxxxxx>
> To: linux-kernel@xxxxxxxxxxxxxxx, stable@xxxxxxxxxx
> Cc: Justin Forbes <jmforbes@xxxxxxxxxxx>,
>     Zwane Mwaikambo <zwane@xxxxxxxxxxxxxxxx>, Theodore Ts'o <tytso@xxxxxxx>,
>     Randy Dunlap <rdunlap@xxxxxxxxxxxx>,
>     Chuck Wolber <chuckw@xxxxxxxxxxxxxxxx>, torvalds@xxxxxxxx, akpm@xxxxxxxx,
>     alan@xxxxxxxxxxxxxxxxxxx, Linus Torvalds <torvalds@xxxxxxxx>,
>     Chris Wright <chrisw@xxxxxxxx>
> Subject: [PATCH 04/11] hpt366: write the full 4 bytes of ROM address,
>     not just low 1 byte
>
> -stable review patch.  If anyone has any objections, please let us know.
> ------------------
>
> This is one heck of a confused driver.  It uses a byte write to a dword
> register to enable a ROM resource that it doesn't even seem to be using.
>
> "Lost and wandering in the desert of confusion"
>
> Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>
> Signed-off-by: Chris Wright <chrisw@xxxxxxxx>
> ---
> drivers/ide/pci/hpt366.c |    8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> Index: linux-2.6.13.y/drivers/ide/pci/hpt366.c
> ===================================================================
> --- linux-2.6.13.y.orig/drivers/ide/pci/hpt366.c
> +++ linux-2.6.13.y/drivers/ide/pci/hpt366.c
> @@ -1334,9 +1334,13 @@ static int __devinit init_hpt366(struct
> static unsigned int __devinit init_chipset_hpt366(struct pci_dev *dev, const char *name)
> {
> 	int ret = 0;
> -	/* FIXME: Not portable */
> +
> +	/*
> +	 * FIXME: Not portable. Also, why do we enable the ROM in the first place?
> +	 * We don't seem to be using it.
> +	 */
> 	if (dev->resource[PCI_ROM_RESOURCE].start)
> -		pci_write_config_byte(dev, PCI_ROM_ADDRESS,
> +		pci_write_config_dword(dev, PCI_ROM_ADDRESS,
> 			dev->resource[PCI_ROM_RESOURCE].start | PCI_ROM_ADDRESS_ENABLE);
>
> 	pci_write_config_byte(dev, PCI_CACHE_LINE_SIZE, (L1_CACHE_BYTES / 4));
>
> --
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies. And the other way is to make it so complicated that there are no obvious deficiencies.
 -- C.A.R. Hoare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/