Re: [PATCH] Permanently fix kernel configuration include mess (was: Missing #include <config.h>)

From: Sergey Vlasov
Date: Wed Sep 14 2005 - 08:48:59 EST


On Wed, 14 Sep 2005 01:39:44 -0700 Andrew Morton wrote:

> Russell King <rmk+lkml@xxxxxxxxxxxxxxxx> wrote:
> >
> > LINUXINCLUDE := -Iinclude \
> > - $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include)
> > + $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) \
> > + -imacros include/linux/autoconf.h
>
> This means that over time the kernel will fail to compile correctly without
> `-imacros include/linux/autoconf.h'.
>
> That's OK for the kernel, but not for out-of-tree stuff. Those drivers
> will need to add the new gcc commandline option too.

You mean out-of-tree drivers which don't use the kernel makefiles when
compiling for 2.6? Are there such beasts, and do we care about them?

(For 2.4 such crap was almost everywhere; for 2.6 the situation seems
to be better.)

Attachment: pgp00000.pgp
Description: PGP signature