Re: [PATCH 2/2] New Omnikey Cardman 4000 driver

[Stefan Smietanowski]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Morton wrote:
> Harald Welte <laforge@xxxxxxxxxxxx> wrote:
> 
>>Add new Omnikey Cardman 4000 smartcard reader driver
> 
> 
> - All the open-coded mdelays() are wrong:
> 
>   #define	T_10MSEC	msecs_to_jiffies(10)
>   ...
> 		mdelay(T_10MSEC);
> 
>   mdelay() already takes a jiffies argument.

And isn't that what he's doing?

He wants 10ms. Converts to jiffies (msec_to_jiffies())
and passes it to mdelay().

mdelay(T_10MSEC);
mdelay(msecs_to_jiffies(10));

// Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (MingW32)

iD8DBQFDKAeTBrn2kJu9P78RAh9AAKCuNe3gGCYfi3yEVLglF4Wr1+1CtQCgus3n
ePboO9jbsSSaDkLrG00kvbM=
=k/B4
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/