Re: [PATCH] add PCI IDs so RME32 and RME96 drivers build

From: Takashi Iwai
Date: Wed Sep 14 2005 - 04:31:53 EST


At Tue, 13 Sep 2005 20:52:53 -0700,
Roland Dreier wrote:
>
> While doing an allyesconfig build, I noticed that the commit
>
> commit 8cdfd2519c6c9a1e6057dc5970b2542b35895738
> Author: Takashi Iwai <tiwai@xxxxxxx>
> Date: Wed Sep 7 14:08:11 2005 +0200
>
> [ALSA] Remove superfluous PCI ID definitions
>
> broke the RME32 and RME96 drivers, since the PCI IDs they use seem to
> have changed names. Here's a patch to fix this -- compile tested
> only, since I have no idea what the hardware even is.
>
>
> Fix the build of the RME32 and RME96 drivers by having them use the
> PCI_DEVICE_ID_RME_xxx names defined in <linux/pci_ids.h> instead of
> the PCI_DEVICE_ID_xxx names that they used to define themselves.
>
> Also fix the typo in the id PCI_DEVICE_IDRME__DIGI96_8_PAD_OR_PST
> so the name is PCI_DEVICE_ID_RME_DIGI96_8_PAD_OR_PST.
>
> Signed-off-by: Roland Dreier <rolandd@xxxxxxxxx>

Thanks. It seems that I submitted an older file.
It was intentional to use PCI_DEVICE_ID_DIGI96* to keep the patch
smaller. But, PCI_DEVICE_ID_RME_* looks more consistent.

Please apply it.

Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/