Re: [PATCH 2.6.13.1] Patch for invisible threads

[Al Viro]

On Tue, Sep 13, 2005 at 08:47:02PM -0500, Sripathi Kodi wrote:
> Linus Torvalds wrote:
> 
> >I don't think this is wrong per se, but you shouldn't take the tasklist 
> >lock normally. You're better off just doing
> 
> Linus,
> 
> I incarporated the path that doesn't hold tasklist lock unnecessarily. The 
> patch is below. This seems to work without any problems for me.
> 
> If the decision is to remove ->permission, I can send a small patch I have 
> that removes .permission entry from proc_task_inode_operations. Either way 
> fixes the problem I found.

NAK.  Even if equivalent of that kludge might be tolerable for our purposes,
it does _not_ belong on any of the normal codepaths.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/