Re: [PATCH] cpuset semaphore depth check optimize

From: Paul Jackson
Date: Tue Sep 13 2005 - 17:22:32 EST


Ingo, confirming Linus's suggestion:
> btw., this is how the -rt tree implements (read-)nesting for rwsems and
> rwlocks. The more sharing and embedding of types and primitives, the
> more compact the whole code becomes, and the easier it is to change
> fundamental properties.

I completely agree.

Such is the art of fine programming.

My basic concern was that Linus was trying to put lipstick
on a pig.

If one gets the underlying structure right, then one should
package it in the best way one can, such as you and Linus
describe.

If one has a hack, better to leave it naked to the world,
with a minimum of artiface.

That way it attracts attention from those who know better
and are repulsed. And that way, when something better
comes along, it will be easy to remove the simple hack.

It looks like Roman is on my case. This is good.

(Of course, if you have a barn full of hogs, maybe
it's time to paint the barn ;).

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/