Re: [PATCH] error path in setup_arg_pages() misses vm_unacct_memory()

[Kirill Korotaev]

> > This patch fixes error path in setup_arg_pages() functions, since it 
> > misses vm_unacct_memory() after successful call of 
> > security_vm_enough_memory(). Also it cleans up error path.
>
> Ugh.  The identifier `security_vm_enough_memory()' sounds like some
> predicate which has no side-effects.  Except it performs accounting.  Hence
> bugs like this.
yup, this is really done in a leading-to-bugs way... :(
maybe it is worth moving vm_acct_memory() out of 
security_vm_enough_memory()? what do you think?

> It's a shame that you mixed a largeish cleanup along with a bugfix - please
> don't do that in future.
not a problem :) thanks for your time and looking at the patches I sent.

Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/