Re: 2.6.13-mm3 [OOPS] vfs, page_owner, full reproductively, badnessin vsnprintf

[Andrew Morton]

Michal Piotrowski <michal.k.k.piotrowski@xxxxxxxxx> wrote:
>
> Hi,
> 
> On 12/09/05, Alexander Nyberg <alexn@xxxxxxxxx> wrote:
> > 
> > Gah, I'm such a fantastic programmer.
> > 
> > I don't know what mc is up to but the error checking in read_page_owner
> > is flawed wrt snprintf which could cause the 'size' argument to snprintf
> > to become negative and if so overwrite beyond 'buf'.
> > 
> > Again, I fail to see how mc causes this to happen, but this fixes it
> > by proper error checking.
> > 
> > Signed-off-by: Alexander Nyberg <alexn@xxxxxxxxx>
> 
> Thanks, patch solved problem.

Thanks.

> Here is version, that clean apply on 2.6.13-mm3. Can you review it?

That patch is all wordwrapped.

How doe sit differe from Alex's patch?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/