Re: [PATCH] 2.6.13 flocks_remove_flock hits BUG();

[Antonio Amorim]

Jakub W. Jozwicki <jakub007@...> writes: 
 
>  
> Because of incomplete conditional flocks_remove_flock runs into    
> BUG() which is below 'ifs'. This was visible with using unionfs.   
>  
> --- locks.c	2005-09-02 16:38:40.770509784 +0200      
> +++ locks-fixed.c	2005-09-02 16:37:22.000000000 +0200      
>  <at>  <at>  -1908,7 +1908,7  <at>  <at>       
>  
>  	while ((fl = *before) != NULL) {      
>  		if (fl->fl_file == filp) {      
> -			if (IS_FLOCK(fl)) {      
> +			if (IS_FLOCK(fl) || IS_POSIX(fl)) {      
>  				locks_delete_lock(before);      
>  				continue;      
>  			}      
>  
 
What was the UNIONFS version that you were able to compile with the 2.6.13 
kernel. Did it work ok after applying the patrch? 
 
All the best, 
Antonio Amorim 
 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/