Re: [PATCH 10/10] drivers/char: pci_find_device remove (drivers/char/watchdog/i8xx_tco.c)

[Matthieu CASTET]

Le Sat, 10 Sep 2005 16:58:49 -0400, Jeff Garzik a écrit :

> Jiri Slaby wrote:
>> diff --git a/drivers/char/watchdog/i8xx_tco.c b/drivers/char/watchdog/i8xx_tco.c
>> --- a/drivers/char/watchdog/i8xx_tco.c
>> +++ b/drivers/char/watchdog/i8xx_tco.c
>> -	while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL) {
>> +	for_each_pci_dev(dev)
>>  		if (pci_match_id(i8xx_tco_pci_tbl, dev)) {
>>  			i8xx_tco_pci = dev;
>>  			break;
>>  		}
>> -	}
> 
> 
> Surely there is a better way to handle bridge matching?
> 
That what is already done in drivers/char/hw_random.c ...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/