Re: [GIT PATCH] More PCI patches for 2.6.13

From: John W. Linville
Date: Sat Sep 10 2005 - 13:34:13 EST


On Fri, Sep 09, 2005 at 04:22:25PM -0700, Linus Torvalds wrote:

> the return value of "pci_enable_wake()" for example. There's really no
> real reason to ever care, as far as I can tell - if it fails, there's
> nothing you can really do about it anyway.
>
> Also, in general, the fact is that things like "pci_set_power_state()"
> might fail in _theory_, but we just don't care. A driver that doesn't

But, aren't these arguments for changing the functions to return void?
If there is never any point in checking the results, then why have
results at all?

John
--
John W. Linville
linville@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/