Re: [PATCH] [2.6.13-mm2] set IBM ThinkPad extras to default n in Kconfig

[Andi Kleen]

On Saturday 10 September 2005 11:42, Borislav Petkov wrote:
> On Fri, Sep 09, 2005 at 06:25:00PM +0200, Roman Zippel wrote:
> > The best would be to avoid using defaults completely, unless the
> > resulting kernel is non-functional (e.g. it doesn't compile or boot).
> > So far it's still the responsibility of the user to explicitly turn
> > everything on he needs (at least until we have a functional autoconfig).
> > BTW distros are not the only users, from them I would expect how to
> > configure a kernel.
>
> Actually, this sounds pretty sane and IMHO is somehow the biggest common
> denominator concerning linux users and their kernel configuration
> recreational activities :); but seriously, going all over the menus of
> Kbuild and turning everything off is a lot of work compared to turning on
> the several things I need on my system. "default m" is also not a good
> thing since compiling of unnecessary modules is simply dumb for a system
> that's just not going to use them.

The new driver dcdbas driver in -git9 seems to have inherited that bad habit 
too. Grr ... Patch appended.

Roman - can you perhaps just forbod default m in Kconfig? I don't think it 
makes any sense.

-Andi

Don't set dcdbas driver to default m

It's nasty to set random drivers to default m because people
who just press enter on make oldconfig get these.
Remove the default m

Signed-off-by: Andi Kleen <ak@xxxxxxx>

Index: linux/drivers/firmware/Kconfig
===================================================================
--- linux.orig/drivers/firmware/Kconfig
+++ linux/drivers/firmware/Kconfig
@@ -71,7 +71,6 @@ config DELL_RBU
 config DCDBAS
 	tristate "Dell Systems Management Base Driver"
 	depends on X86 || X86_64
-	default m
 	help
 	  The Dell Systems Management Base Driver provides a sysfs interface
 	  for systems management software to perform System Management
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/