Re: [PATCH] i386 CFI annotations

[Richard Henderson]

On Fri, Sep 09, 2005 at 08:51:57AM +0200, Jan Beulich wrote:
> >>> Tom Rini <trini@xxxxxxxxxxxxxxxxxxx> 08.09.05 18:13:34 >>>
> >On Thu, Sep 08, 2005 at 05:57:55PM +0200, Jan Beulich wrote:
> >
> >> >> +	CFI_ADJUST_CFA_OFFSET 4;\
> >> >> +	/*CFI_REL_OFFSET es, 0;*/\
> >> >>  	pushl %ds; \
> >> >> +	CFI_ADJUST_CFA_OFFSET 4;\
> >> >> +	/*CFI_REL_OFFSET ds, 0;*/\
> >> >
> >> >Adding new commented out code never wins new friends. :)
> >> 
> >> I know. But how would you indicate functionality belonging there
> but
> >> just not provided by the translating utilities. If that's really a
> >> problem, then I would need to teach the respective macros to ignore
> >> certain operands.
> >
> >Not provided by binutils or ?
> 
> Not provided for even by the spec; if it was just binutils missing them
> I'd have added this already.

You know this is just convention, right?  And that binutils allows
you to put any column numbers you like?  So all you have to do it
match whatever debugger you're planning to use.  Make something up.


r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/