Re: [PATCH] bogus #if (acpi/blacklist)

[viro]

On Fri, Sep 09, 2005 at 06:19:02PM +0200, Eric Piel wrote:
> 09/09/2005 06:07 PM, viro@xxxxxxxxxxxxxxxxxx wrote/a ??crit:
> >Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> >----
> >diff -urN RC13-git8-base/drivers/acpi/blacklist.c 
> >current/drivers/acpi/blacklist.c
> >--- RC13-git8-base/drivers/acpi/blacklist.c	2005-09-08 
> >23:42:49.000000000 -0400
> >+++ current/drivers/acpi/blacklist.c	2005-09-09 11:28:44.000000000 -0400
> >@@ -73,7 +73,7 @@
> > 	{""}
> > };
> > 
> >-#if	CONFIG_ACPI_BLACKLIST_YEAR
> >+#ifdef	CONFIG_ACPI_BLACKLIST_YEAR
> > 
> > static int __init blacklist_by_year(void)
> > {
> 
> Are you sure about this? IIRC, CONFIG_ACPI_BLACKLIST_YEAR is defined to 
> 0 when it should not be blacklisted. In drivers/acpi/Kconfig :
>     Enter 0 to disable this mechanism and allow ACPI to
>     run by default no matter what the year.  (default)

Hmm....  Oh, lovely - so we have that non-zero if set, 0 if it's i386 or
amd64 and not set and not defined if it's ia64 and not set.

Sigh...  It should be left as #if, of course, but I suspect that cleaner way to
deal with that would be (in Kconfig)

config ACPI_BLACKLIST_YEAR
        int "Disable ACPI for systems before Jan 1st this year" if X86
        default 0

Roman?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/