RE: [PATCH] [2.6.13-mm2] set IBM ThinkPad extras to default n in Kconfig

[Brown, Len]

>Hi Andrew,
>
>   I think the following isn't on purpose but the IBM Thinkpad acpi
>   extras default to y in Kconfig. The patch below fixes it:
>
>   Signed-off-by: <petkov@xxxxxxxxxxxxxxx>
>
>
>--- drivers/acpi/Kconfig.orig	2005-09-09 09:46:26.000000000 +0200
>+++ drivers/acpi/Kconfig	2005-09-09 09:46:46.000000000 +0200
>@@ -197,7 +197,7 @@ config ACPI_ASUS
> config ACPI_IBM
> 	tristate "IBM ThinkPad Laptop Extras"
> 	depends on X86
>-	default y
>+	default n
> 	---help---
> 	  This is a Linux ACPI driver for the IBM ThinkPad 

Before we had "default m", since that is how a distro
is expected to compile this, and other, "ACPI drivers".

But we got complaits that _nothing_ should be "default m",
so I changed it to "default y".  Maybe that was simplistic --
button should be "default y", but the platform drivers should
all be "default n"?

I'm not sure what to do here -- what use-model
should we tune default Kconfig for?

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/