Re: [PATCH] add stricmp

From: Jan Beulich
Date: Thu Sep 08 2005 - 10:27:46 EST


>>> Christoph Hellwig <hch@xxxxxxxxxxxxx> 08.09.05 17:17:54 >>>
>On Thu, Sep 08, 2005 at 05:05:06PM +0200, Jan Beulich wrote:
>> (Note: Patch also attached because the inline version is certain to
get
>> line wrapped.)
>>
>> While strnicmp existed in the set of string support routines,
stricmp
>> didn't, which this patch adjusts.
>
>I don't thing we should do case-insenstitive comparims in kernel, and
>in the few cases where we must (legacy OS fileystem support) it needs
>to be NLS-capable.

Then how am I supposed to do ASCII-only case-insensitive compares (i.e.
reading config files)? And why is there a strnicmp? If this is not going
to be available as general library routine, I'd just have to add this to
a place where it doesn't really belong.

>But once again we need to see the users anyway. You're adding tons
of
>bloat in your patches without showing us an actually useful user.

The intended user can be seen at
http://forge.novell.com/modules/xfmod/project/?nlkd (and see also my
previous reply to your earlier, similar complaint).

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/