Re: [-mm patch 3/5] SharpSL: Abstract c7x0 specifics from Corgi Touchscreen driver

[Russell King]

On Tue, Sep 06, 2005 at 12:53:50PM +0100, Richard Purdie wrote:
> Separate out the Sharp Zaurus c7x0 series specific code from the Corgi
> Touchscreen driver. Use the new functions in corgi_lcd.c via sharpsl.h
> for hsync handling and pass the IRQ as a platform device resource. Move
> a function prototype into the w100fb header file where it belongs.

This patch looks a little confused.

> +	corgi_ts->irq_gpio = platform_get_irq(pdev, 0);

So irq_gpio is an IRQ number.

> @@ -313,14 +324,14 @@
>  	input_register_device(&corgi_ts->input);
>  	corgi_ts->power_mode = PWR_MODE_ACTIVE;
>  
> -	if (request_irq(CORGI_IRQ_GPIO_TP_INT, ts_interrupt, SA_INTERRUPT, "ts", corgi_ts)) {
> +	if (request_irq(IRQ_GPIO(corgi_ts->irq_gpio), ts_interrupt, SA_INTERRUPT, "ts", corgi_ts)) {

Or is it.  It _should_ be an IRQ number.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/