Re: [PATCH 1/5][BUG] SUBCPUSETS: fix for cpusets minor problem

[Robin Holt]

On Thu, Sep 08, 2005 at 02:40:53PM +0900, KUROSAWA Takahiro wrote:
> This patch fixes minor problem that the CPUSETS have when files
> in the cpuset filesystem are read after lseek()-ed beyond the EOF.
> 
> Signed-off-by: KUROSAWA Takahiro <kurosawa@xxxxxxxxxxxxx>
> 
> --- from-0001/kernel/cpuset.c
> +++ to-work/kernel/cpuset.c	2005-09-05 20:26:18.075772762 +0900
> @@ -984,6 +984,10 @@ static ssize_t cpuset_common_file_read(s
>  	*s++ = '\n';
>  	*s = '\0';
>  
> +	/* Do nothing if *ppos is at the eof or beyond the eof. */
> +	if (s - page <= *ppos)
> +		return 0;
> +
>  	start = page + *ppos;
>  	n = s - start;
>  	retval = n - copy_to_user(buf, start, min(n, nbytes));


Paul,  I think this should go in regardless of the other subcpuset
changes being proposed.  What do you think?

Robin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/