Re: [patch 8/8] PCI Error Recovery: PPC64 core recovery routines

From: Linas Vepstas
Date: Mon Aug 29 2005 - 11:01:07 EST


On Fri, Aug 26, 2005 at 09:37:36AM +1000, Benjamin Herrenschmidt was heard to remark:
> On Fri, 2005-08-26 at 09:18 +1000, Paul Mackerras wrote:
> > Benjamin Herrenschmidt writes:
> >
> > > Ok, so what is the problem then ? Why do we have to wait at all ? Why
> > > not just unplug/replug right away ?
> >
> > We'd have to be absolutely certain that the driver could not possibly
> > take another interrupt or try to access the device on behalf of the
> > old instance of the device by the time it returned from the remove
> > function. I'm not sure I'd trust most drivers that far...
>
> Hrm... If a driver gets that wrong, then it will also blow up when
> unloaded as a module.


:) We've discovered two, so far, that blow up when unloaded:
lpfc and e1000. I beleive these are now fixed in mainline.

--linas
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/