Re: [patch] IBM HDAPS accelerometer driver, with probing.

From: Alan Cox
Date: Sat Aug 27 2005 - 09:20:48 EST


On Sad, 2005-08-27 at 02:29 -0300, Arnaldo Carvalho de Melo wrote:
> > unlikely() can result in better, smaller, faster code. and it acts as a
> > nice directive to programmers reading the code.
>
> Agreed, keep them :-)

If the unlikely() hints are being used correctly and the compiler is
doing the right thing then it ought to be worthwhile, if not then fix
the compiler.

Remember however unlikely() does have a code size cost on some
processors and a small performance cost so it really has to mean
very_unlikely().

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/