Re: [PATCH] acpi: Handle cpu_index greater than 256 properly in processor_core.c

[Ingo Oeser]

Hi Venkatesh,

On Saturday 27 August 2005 02:07, Venkatesh Pallipadi wrote:
> Fix convert_acpiid_to_cpu function to handle cpu_index greater than 256. This 
> patch also prevents a warning in IA64 cross-compile of this file 
> (drivers/acpi/processor_core.c:517: warning: comparison is always false due 
> to limited range of data type).

Why don't you just change the datatype to "unsigned int" and 
the return failure value to NR_CPUS?

That reduces the code changes and leaves the code quite clear.
It should also reduce compiled code size by some bytes, but I'm not
sure about that one.


Regards

Ingo Oeser

Attachment: pgp00000.pgp
Description: PGP signature