Re: [patch 1/2] Fixup symlink function pointers for hppfs [for 2.6.13]

From: Al Viro
Date: Fri Aug 26 2005 - 14:01:14 EST


On Fri, Aug 26, 2005 at 04:57:44PM +0200, blaisorblade@xxxxxxxx wrote:
>
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@xxxxxxxx>
>
> Update hppfs for the symlink functions prototype change.
> Should be trivial, but please verify it's correct.
>
> Yes, I know the code I leave there is still _bogus_, see next patch for this.

Assuming that the next patch was "hppfs: fix symlink error path",
you've still left BS in there -

> proc_file = dentry_open(dget(proc_dentry), NULL, O_RDONLY);

is obviously wrong; at the very least you need vfsmount in there.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/