Re: [PATCH] move tasklist walk from cfq-iosched to elevator.c

[Jens Axboe]

On Fri, Aug 26 2005, Christoph Hellwig wrote:
> We're trying to get rid of as much as possible tasklist walks, or at
> least moving them to core code.  This patch falls into the second
> category.
> 
> Instead of walking the tasklist in cfq-iosched move that into
> elv_unregister.  The added benefit is that with this change the as
> ioscheduler might be might unloadable more easily aswell.
> 
> The new code uses read_lock instead of read_lock_irq because the
> tasklist_lock only needs irq disabling for writers.

Looks innocent enough, fine with me. 'as' will need additional work to
be unloadable, but it wont break anything since it's running with an
elevated module count right now anyways.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/