Re: [PATCH] removes filp_count_lock and changes nr_files type to atomic_t

From: Christoph Hellwig
Date: Thu Aug 25 2005 - 09:56:31 EST


On Fri, Aug 26, 2005 at 12:51:30AM +1000, Nick Piggin wrote:
> Eric Dumazet wrote:
> >Nick Piggin a ?crit :
> >
>
> >>Would you just be able to add the atomic sysctl handler that
> >>Christoph suggested?
> >>
> >
> >Quite a lot of work indeed, and it would force to convert 3 int
> >(nr_files, nr_free_files, max_files) to 3 atomic_t. I feel bad
> >introducing a lot of sysctl rework for a tiny change (removing
> >filp_count_lock)
> >
>
> True, I didn't notice that.

Well, it would with a generic atomic_t handler. With a special
handler for this situation it's not needed.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/