Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

[Adrian Bunk]

On Wed, Aug 24, 2005 at 03:57:36PM +0100, Al Viro wrote:
> On Wed, Aug 24, 2005 at 01:26:55PM +0200, Adrian Bunk wrote:
> > On Tue, Aug 23, 2005 at 10:45:41PM +0100, Al Viro wrote:
> > 
> > > infiniband uses PCI helpers all over the place (including the core parts) and
> > > won't build without PCI.
> > >...
> > 
> > CONFIG_INFINIBAND=y and CONFIG_PCI=n compiles for me on i386.
> > 
> > Can you post the compile error you got?
> 
> On which platform?  There's a lot of them on the architectures that do not

As I said, on i386.

> have PCI at all - same situation as with firewire.  Note that you won't
> get any low-level drivers on PCI-less config even on i386, so while I
> agree that more accurate dependency would be nice here (as well as for
> drivers/ieee1394), for all practical purposes the same dependency works
> here.
> 
> BTW, this is more general question - do we expect pci helpers to be present
> on all platforms and do we consider their use acceptable in code that does
> not depend on PCI?
>...

Are you talking about the ones that already have dummy functions for the 
PCI=n case in include/linux/pci.h, or about other functions?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/