Re: [PATCH] ARCH_HAS_IRQ_PER_CPU avoids dead code in __do_IRQ()

[Karsten Wiese]

Am Sonntag, 7. August 2005 13:07 schrieb Ingo Oeser:
> Last argument: Many kernel developers -- including Linus -- 
> don't like "#if" in C files and prefer them in headers. 
> Their reasons might be similiar to my own.

What about writing
	if(CHECK_IRQ_PER_CPU(desc->status)) {
		...
	}
in __do_IRQ(),
and
	#if defined(ARCH_HAS_IRQ_PER_CPU)
		#define IRQ_PER_CPU	256	/* IRQ is per CPU */
		#define CHECK_IRQ_PER_CPU(var) ((var) & IRQ_PER_CPU)
	#else
		#define CHECK_IRQ_PER_CPU(var) 0
	#endif
in "include/linux/irq.h" then?

   Gruesse,
   Karsten

	

	
		
___________________________________________________________ 
Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/