Re: [PATCH] 8/8 Create MMU 2/3 level accessors in the sub-arch layer (i386)

From: Christoph Hellwig
Date: Sat Aug 06 2005 - 07:03:37 EST


On Sat, Aug 06, 2005 at 01:58:36PM +0200, Andi Kleen wrote:
> > > I think that patch is really ugly - it makes hacking VM on i386
> > > even more painful than it already is because the convolutes the file
> > > structure even more. Hope it is not applied.
> >
> > Especially as there's been no user shown for it, similar to all the other
> > ugly patches from vmware.
>
> Well, some of it can be counted as cleanup or even tuning like the excellent
> switch_to patch. But not that one and some of the more intrusive patches.

Yeah, I said ugly ones specificly. There's been some nice previous ones,
but most in this series (all the move of stuff to subarches) are rather
horrible and lack lots of explanation.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/