Re: [PATCH] Export handle_mm_fault to modules.

From: Linus Torvalds
Date: Fri Aug 05 2005 - 18:03:39 EST




On Fri, 5 Aug 2005, Stelian Pop wrote:
>
> handle_mm_fault changed from an inline function to a non-inline one
> (__handle_mm_fault), which is not available to external kernel modules.
> The patch below fixes this.

We didn't use to export handle_mm_fault before, and it wasn't an inline
function in 2.6.12 either.

And no modules I know of call handle_mm_fault(). What module causes
problems? That's very much a kernel internal function.

IOW, there's something wrong in your setup. It can't have worked on 2.6.12
either,

The only thing that has ever exported it afaik is

arch/ppc/kernel/ppc_ksyms.c:EXPORT_SYMBOL(handle_mm_fault); /* For MOL */

and that looks pretty suspicious too (what is MOL, and regardless,
shouldn't it be an EXPORT_SYMBOL_GPL?).

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/