Re: [patch] preempt-trace.patch (mono preempt-trace)

From: Dominik Karall
Date: Fri Aug 05 2005 - 15:48:33 EST


On Friday 05 August 2005 22:04, Ingo Molnar wrote:
> * Dominik Karall <dominik.karall@xxxxxxx> wrote:
> > With FRAME_POINTERS enabled:
> >
> > BUG: mono[3193] exited with nonzero preempt_count 1!
> > ---------------------------
> >
> > | preempt count: 00000001 ]
> > | 1 level deep critical section nesting:
> >
> > ----------------------------------------
> > .. [<ffffffff80400a46>] .... _spin_lock+0x16/0x80
> > .....[<ffffffff801ed30c>] .. ( <= sys_semtimedop+0x28c/0x7c0)
>
> thanks. It seems semundo->lock somehow leaked. One possibility would be
> of semundo->refcount going from 2 to 1 while another thread has it
> locked. I dont see what prevents this scenario from happening. To test
> this theory, could you apply the patch below, which will do semundo
> locking not conditional on the refcount - does it fix the bug?

yeah! it works, great job! :)

dominik

Attachment: pgp00000.pgp
Description: PGP signature