Re: [PATCH] implicit declaration of function `page_cache_release'

[Benoit Boissinot]

On 7/8/05, Olaf Hering <olh@xxxxxxx> wrote:
> 
> In file included from include2/asm/tlb.h:31,
>                  from linux-2.6.13-rc2-olh/arch/ppc64/kernel/pSeries_lpar.c:37:
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_flush_mmu':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:77: warning: implicit declaration of function `release_pages'
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h: In function `tlb_remove_page':
> linux-2.6.13-rc2-olh/include/asm-generic/tlb.h:117: warning: implicit declaration of function `page_cache_release'
> 
This went in 2.6.13-rc3 (commit
542d1c88bd7f73e2e59d41b12e4a9041deea89e4), and broke sparc compilation
because of the following circular dependency:
asm-sparc/pgtable include linux/swap.h
linux/swap.h include now linux/pagemap.h
linux/pagemap.h include linux/mm.h
linux/mm.h include asm/pgtable.h

I haven't found a satisfactory way to resolve this, but i think the
patch should be removed (it removes a warning but breaks an
architecture).

Regards,

Benoit Boissinot

> Index: linux-2.6.13-rc2-olh/include/linux/pagemap.h
>  ===================================================================
> --- linux-2.6.13-rc2-olh.orig/include/linux/swap.h
> +++ linux-2.6.13-rc2-olh/include/linux/swap.h
> @@ -7,6 +7,7 @@
>  #include <linux/mmzone.h>
>  #include <linux/list.h>
>  #include <linux/sched.h>
> +#include <linux/pagemap.h>
>  #include <asm/atomic.h>
>  #include <asm/page.h>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/