Re: areca-raid-linux-scsi-driver.patch added to -mm tree

From: Jens Axboe
Date: Fri Aug 05 2005 - 05:06:09 EST


On Fri, Aug 05 2005, Arjan van de Ven wrote:
> > +
> > + while (1) {
> > + int64_t span4G, length0;
> > + PSG64ENTRY pdma_sg = (PSG64ENTRY) psge;
> > +
> > + span4G =
> > + (int64_t) address_lo + tmplength;
> > + pdma_sg->addresshigh = address_hi;
> > + pdma_sg->address = address_lo;
> > + if (span4G > 0x100000000ULL) {
> > + /*see if cross 4G boundary */
>
> the linux block layer will guarantee that that doesn't happen afaik

yes, it even does it by default. so that code can be removed.

I agree with the other suggestions made.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/