Re: [PATCH] push rounding up of relative request to schedule_timeout()

From: Roman Zippel
Date: Thu Aug 04 2005 - 14:02:57 EST


Hi,

On Thu, 4 Aug 2005, Nishanth Aravamudan wrote:

> The comment for schedule_timeout() claims:
>
> * Make the current task sleep until @timeout jiffies have
> * elapsed.
>
> Currently, it does not do so. I was simply trying to make the function
> do what it claims it does.

What makes you think the comment is correct? This comment was added at
2.4.3, while schedule_timeout() has this behaviour since it was added at
2.1.127.

> My point was that the +1 issues (potential
> infinite timeouts) are a problem with *jiffies* not milliseconds. And
> thus need to be pushed down to the jiffies layer. I think my explanation
> was pretty clear.

Not really, could you go into more details why it's "a problem with
*jiffies* not milliseconds"?

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/