Re: Calling suspend() in halt/restart/shutdown -> not a good idea

[Benjamin Herrenschmidt]

On Tue, 2005-08-02 at 16:45 +0200, Pavel Machek wrote:
> Hi!
> 
> > >> Why are we calling driver suspend routines in these ? This is _not_
> > >
> > > Well, reason is that if you remove device_suspend() you'll get
> > > emergency hard disk park during powerdown. As harddrives can survive
> > > only limited number of emergency stops, that is not a good idea.
> > 
> > Then the practical question is: do we suspend the disk by
> > calling device_suspend() for every device.  Or do we modify
> > the ->shutdown() method for the disk.
> 
> The additional data in pm_message_t are usefull, and sharing code
> between suspend-to-ram and suspend-to-disk is usefull => option #1...

No.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/